Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GoogleDriveLoader no longer filters based on file_type paramter #6257

Closed
1 of 14 tasks
tedhli opened this issue Jun 15, 2023 · 1 comment · Fixed by #6258
Closed
1 of 14 tasks

GoogleDriveLoader no longer filters based on file_type paramter #6257

tedhli opened this issue Jun 15, 2023 · 1 comment · Fixed by #6258

Comments

@tedhli
Copy link
Contributor

tedhli commented Jun 15, 2023

System Info

Python 3.10, langchain=0.0.201

Who can help?

@eyurtsev

Information

  • The official example notebooks/scripts
  • My own modified scripts

Related Components

  • LLMs/Chat Models
  • Embedding Models
  • Prompts / Prompt Templates / Prompt Selectors
  • Output Parsers
  • Document Loaders
  • Vector Stores / Retrievers
  • Memory
  • Agents / Agent Executors
  • Tools / Toolkits
  • Chains
  • Callbacks/Tracing
  • Async

Reproduction

Load any folder with multiple file types and pass the file_type parameter. It will not filter any types.

Expected behavior

It should filter to the provided list of file types.
@tedhli
Copy link
Contributor Author

tedhli commented Jun 15, 2023 •
edited

This PR (#4926) originally added the functionality.

This PR (#5220) removed the functionality when adding code to filter trashed files by using the files variables instead of _files variable.

@tedhli tedhli mentioned this issue Jun 15, 2023
Merged
hwchase17 pushed a commit that referenced this issue Jun 19, 2023
@tedhli
Iterate through filtered file types instead of all listed files (#6258)
112695e 
# Iterate through filtered file types instead of all listed files

Fixes #6257

#4926 originally added the
functionality to filter by file type, storing the filtered files in
`_files`

#5220 removed the
functionality when adding code to filter trashed files by using the
`files` variables instead of the `_files` variable.

This PR simply adds the functionality back by using `_files` again.

#### Who can review?

@hwchase17 - project lead
@eyurtsev
kacperlukawski pushed a commit to kacperlukawski/langchain that referenced this issue Jun 29, 2023
@tedhli @kacperlukawski
Iterate through filtered file types instead of all listed files (lang…
2f00831 
…chain-ai#6258)

# Iterate through filtered file types instead of all listed files

Fixes langchain-ai#6257

langchain-ai#4926 originally added the
functionality to filter by file type, storing the filtered files in
`_files`

langchain-ai#5220 removed the
functionality when adding code to filter trashed files by using the
`files` variables instead of the `_files` variable.

This PR simply adds the functionality back by using `_files` again.

#### Who can review?

@hwchase17 - project lead
@eyurtsev
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Iterate through filtered file types instead of all listed files tedhli/langchain
1 participant
@tedhli