Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Should be able to pass API keys as params rather than requiring them to be in the environment #76

Closed
camjw opened this issue Nov 7, 2022 · 3 comments
Closed

Should be able to pass API keys as params rather than requiring them to be in the environment #76

camjw opened this issue Nov 7, 2022 · 3 comments

Comments

@camjw
Copy link
Contributor

camjw commented Nov 7, 2022

It's just a bit annoying, I want to use this library in production and I currently store credentials not in the environment.

I think the ideal API is like all the AWS SDKs where you can either stick them in the environment OR pass them as params to the llm constructor.

I can do a PR for this if you're accepting PRs?
@hwchase17
Copy link
Contributor

great idea. prs are def being accepted! will keep an eye out for it. at the same time, this is such a good idea im more than happy to work on myself if you dont have the time - lmk

@camjw camjw mentioned this issue Nov 7, 2022
Merged
@camjw
Copy link
Contributor Author

camjw commented Nov 7, 2022

Have opened a PR, happy to make any changes to it though!

hwchase17 pushed a commit that referenced this issue Nov 7, 2022
@camjw
Improve credential handing to allow passing in constructors (#79)
54e325b 
Addresses the issue in #76 by either using the relevant environment
variable if set or using a string passed in the constructor.

Prefers the constructor string over the environment variable, which
seemed like the natural choice to me.
@hwchase17
Copy link
Contributor

merged in! thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@hwchase17 @camjw