[bugfix] Fix persisted chromadb vectorstore #1444
Conversation
If a `persist_directory` param was set, chromadb would throw a warning that ""No embedding_function provided, using default embedding function: SentenceTransformerEmbeddingFunction". and would error with a `Illegal instruction: 4` error. MBP M1 13.2.1, python 3.9. I'm not entirely sure why that error happened, but when using `get_or_create_collection` instead of `list_collection` on our end, the error and warning goes away and chroma works as expected. Added bonus this is cleaner and likely more efficient. `list_collections` builds a new `Collection` instance for each collect, then `Chroma` would just use the `name` field to tell if the collection existed.
|
@timothyasp theres been lots of dev on chroma side - is this error still happening with recent versions? |
|
I'm seeing this right now with chromadb==0.3.11 and langchain==0.0.105 |
|
Yea, I believe so, I’ve been using this patched code now and been pulling
pretty much daily from both upstreams, and things have been working.
On Wed, Mar 8, 2023 at 8:17 PM Harrison Chase ***@***.***> wrote:
@timothyasp <https://github.com/timothyasp> theres been lots of dev on
chroma side - is this error still happening with recent versions?
—
Reply to this email directly, view it on GitHub
<#1444 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAFMY4ZX62S45XEIVH6VZZTW3FKV5ANCNFSM6AAAAAAVP57MYA>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
--
-Tim
|
|
@hwchase17 any chance we can get this merged into a patch release? |
|
tried the fix |
|
@hwchase17 can we get this merged? It seems to be impacting a lot of people |
|
In the meantime I forked the original repos and applied the patch (to be up to date with latest commit). |
|
merging in! sorry for delay! |
|
@hwchase17 I am still getting this error on version |
|
@hwchase17 Can confirm this is still an issue in |
|
@hwchase17 This issue is still there in |
|
Do we know if this error has been resolved I am getting an error message as follows: "You must provide embeddings or a function to compute them". How do I patch my current vectorstore chromadb file? |
If a
persist_directoryparam was set, chromadb would throw a warning that ""No embedding_function provided, using default embedding function: SentenceTransformerEmbeddingFunction". and would error with aIllegal instruction: 4error.This is on a MBP M1 13.2.1, python 3.9.
I'm not entirely sure why that error happened, but when using
get_or_create_collectioninstead oflist_collectionon our end, the error and warning goes away and chroma works as expected.Added bonus this is cleaner and likely more efficient.
list_collectionsbuilds a newCollectioninstance for each collect, thenChromawould just use thenamefield to tell if the collection existed.