Fix incorrect wikipage summaries #2169
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ruiaf
added a commit
to ruiaf/langchain
that referenced
this pull request
Mar 30, 2023
This upsteam wikipedia page loading seems to still have issues. Finding a compromise solution where it does an exact match search and not a search for the completion. See previous PR: langchain-ai#2169
hwchase17
pushed a commit
that referenced
this pull request
Mar 30, 2023
This upsteam wikipedia page loading seems to still have issues. Finding a compromise solution where it does an exact match search and not a search for the completion. See previous PR: #2169
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Creating a page using the title causes a wikipedia search with autocomplete set to true. This frequently causes the summaries to be unrelated to the actual page found.
See: https://github.com/goldsmith/Wikipedia/blob/1554943e8ab463cef5e93081def48fafbdef324e/wikipedia/wikipedia.py#L254-L280