Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix typing for LLMMathChain #2183

Merged
merged 1 commit into from
Mar 30, 2023
Merged

fix typing for LLMMathChain #2183

merged 1 commit into from
Mar 30, 2023

Conversation

benheckmann
Copy link
Contributor

Fix typing in LLMMathChain to allow chat models (#1834). Might have been forgotten in related PR #1807.

hwchase17
hwchase17 approved these changes Mar 30, 2023
View reviewed changes
Copy link
Contributor

@hwchase17 hwchase17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@hwchase17 hwchase17 merged commit fd1fcb5 into langchain-ai:master Mar 30, 2023
@jcomfort4
Copy link
Contributor

Feels like a related change is needed to help with this issue: #2154 -- trying to figure out where the change needs to be made and no luck, but I'm guessing I need to make a similarly simple PR?

@benheckmann benheckmann deleted the fix-llmmathchain-typing-and-prompt branch April 18, 2023 15:08
@stakes stakes mentioned this pull request Apr 29, 2023
Merged
vowelparrot pushed a commit that referenced this pull request Apr 30, 2023
@stakes
fix typing for vectorstore tools (#3808)
ae915c4 
use BaseLanguageModel instead of BaseLLM in BaseVectorStoreTool,
VectorStoreToolkit, and VectorStoreRouterToolkit so chat models work

just like #2183 and #1807 before it!
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hwchase17 hwchase17 hwchase17 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@benheckmann @jcomfort4 @hwchase17