Add encoding parameter to TextLoader #2250
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This merge request proposes changes to the TextLoader class to make it more flexible and robust when handling text files with different encodings. The current implementation of TextLoader does not provide a way to specify the encoding of the text file being read. As a result, it might lead to incorrect handling of files with non-default encodings, causing issues with the content.
|
Similar to #2223 but little more user control. |
chmodsss
reviewed
Apr 1, 2023
|
|
||
| def load(self) -> List[Document]: | ||
| """Load from file path.""" | ||
| with open(self.file_path, encoding="utf-8") as f: | ||
| with open(self.file_path, encoding=self.encoding) as f: |
There was a problem hiding this comment.
Addition of 'r' parameter fixes the UnicodeDecodeError. Could you also add that acc. to #2223
There was a problem hiding this comment.
From first glance, I believe mode='r' is the default, so I do not know why that would cause a problem. https://docs.python.org/3/library/functions.html#open
There was a problem hiding this comment.
That is true. The updated version 0.0.129 did fix that issue. I am not sure why I had that issue in Windows. btw, would it be better if the default encoding is 'utf-8' as opposed to None.
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This merge request proposes changes to the TextLoader class to make it more flexible and robust when handling text files with different encodings. The current implementation of TextLoader does not provide a way to specify the encoding of the text file being read. As a result, it might lead to incorrect handling of files with non-default encodings, causing issues with loading the content.
Benefits: