Add ability to pass kwargs to loader classes in DirectoryLoader, add ability to modify encoding and BeautifulSoup behaviour in BSHTMLLoader
#2275
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…g to `open()` in `BSHTMLLoader`. langchain-ai#2247
… in `DirectoryLoader`. langchain-ai#2247
| @@ -15,3 +18,25 @@ def test_bs_html_loader() -> None: | |||
|
|
|||
| assert metadata["title"] == "Chew dad's slippers" | |||
| assert metadata["source"] == str(file_path) | |||
|
|
|||
|
|
|||
| @pytest.mark.skipif( | |||
There was a problem hiding this comment.
Test will only run on Windows? Not sure this will be run during checks.
|
@hwchase17 Just spotted #2250 - solves the same problem as my PR, but the parameter is just named |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solves #2247. Noted that the only test I added checks for the BeautifulSoup behaviour change. Happy to add a test for
DirectoryLoaderif deemed necessary.