Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: missed deps integrations tests #2560

Merged
merged 2 commits into from Apr 8, 2023
Merged

fix: missed deps integrations tests #2560

merged 2 commits into from Apr 8, 2023

Conversation

sergerdn
Copy link
Contributor

@sergerdn sergerdn commented Apr 7, 2023

Almost all integration tests have failed, but we haven't encountered any import errors yet. Some tests failed due to lazy import issues. It doesn't seem like a problem to resolve some of these errors in the next PR.
I have a headache from resolving conflicts with deeplake and boto3, so I will temporarily comment out boto3.

fix #2426

@sergerdn sergerdn marked this pull request as ready for review April 7, 2023 19:56
@sergerdn sergerdn changed the title Fix/missed deps integrations tests fix: missed deps integrations tests Apr 7, 2023
@sergerdn
Copy link
Contributor Author

sergerdn commented Apr 7, 2023

@hwchase17 I'm ready for review.

Copy link
Contributor

@hwchase17 hwchase17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks again :)

@hwchase17 hwchase17 merged commit cd93364 into langchain-ai:master Apr 8, 2023
9 checks passed
@sergerdn sergerdn deleted the fix/missed-deps-integrations-tests branch April 8, 2023 06:38
@farizrahman4u
Copy link

@sergerdn Have you tried putting the deeplake requirement after boto3? deeplake doesnt have a hard dependency on a specific boto3 version.

@sergerdn
Copy link
Contributor Author

@farizrahman4u

$ poetry add boto3
Using version ^1.26.109 for boto3

Updating dependencies
Resolving dependencies... (4.6s)

Because no versions of deeplake match >3.2.21,<4.0.0
 and deeplake (3.2.21) depends on aioboto3 (10.4.0), deeplake (>=3.2.21,<4.0.0) requires aioboto3 (10.4.0).
And because aioboto3 (10.4.0) depends on aiobotocore (2.4.2)
 and aiobotocore (2.4.2) depends on boto3 (>=1.24.59,<1.24.60), deeplake (>=3.2.21,<4.0.0) requires boto3 (>=1.24.59,<1.24.60).
So, because langchain depends on both deeplake (>=3.2.21,<4.0.0) and boto3 (^1.26.109), version solving failed.

hwchase17 pushed a commit that referenced this pull request Apr 12, 2023
Add more missed imports for integration tests. Bump `pytest` to the
current latest version.
Fix `tests/integration_tests/vectorstores/test_elasticsearch.py` to
update its cassette(easy fix).

Related PR: #2560
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Integration tests failing
3 participants