Fix Sagemaker Batch Endpoints #3249
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dev2049
reviewed
Apr 21, 2023
|
|
||
| from pydantic import Extra, root_validator | ||
|
|
||
| from langchain.llms.base import LLM | ||
| from langchain.llms.utils import enforce_stop_tokens | ||
|
|
||
| INPUT_TYPE = TypeVar("INPUT_TYPE", bound=Union[str, List[str]]) | ||
| OUTPUT_TYPE = TypeVar("OUTPUT_TYPE", bound=Union[str, List[List[float]]]) |
There was a problem hiding this comment.
shouldn't these be used in ContentHandlerBase? prompt: INPUT_TYPE, -> OUTPUT_TYPE
There was a problem hiding this comment.
Yes indeed - seems to have been a tragedy of the merge
hwchase17
approved these changes
Apr 22, 2023
vowelparrot
added a commit
that referenced
this pull request
Apr 26, 2023
Add different typing for @evandiewald 's heplful PR --------- Co-authored-by: Evan Diewald <evandiewald@gmail.com>
vowelparrot
added a commit
that referenced
this pull request
Apr 28, 2023
Add different typing for @evandiewald 's heplful PR --------- Co-authored-by: Evan Diewald <evandiewald@gmail.com>
samching
pushed a commit
to samching/langchain
that referenced
this pull request
May 1, 2023
Add different typing for @evandiewald 's heplful PR --------- Co-authored-by: Evan Diewald <evandiewald@gmail.com>
yanghua
pushed a commit
to yanghua/langchain
that referenced
this pull request
May 9, 2023
Add different typing for @evandiewald 's heplful PR --------- Co-authored-by: Evan Diewald <evandiewald@gmail.com>
This was referenced May 12, 2023
dev2049
pushed a commit
that referenced
this pull request
May 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add different typing for @evandiewald 's heplful PR