fix: OpenAIEmbeddings support for Azure OpenAI Service custom endpoints #3711
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zioproto
force-pushed
the
fix/api-base-azure-openai-embeddings
branch
from
067f6a5
to
37587be
Compare
zioproto
force-pushed
the
fix/api-base-azure-openai-embeddings
branch
from
37587be
to
067f6a5
Compare
|
According to the docs: The But I am setting I am not sure where |
zioproto
force-pushed
the
fix/api-base-azure-openai-embeddings
branch
from
067f6a5
to
8179f72
Compare
|
I refactored the commit into 8179f728d3073765573a9c4ff07bb3ff717cb372 Now it is working for me as expected. |
zioproto
force-pushed
the
fix/api-base-azure-openai-embeddings
branch
from
8179f72
to
279a59b
Compare
|
I pushed a new commit to fix the linting |
hwchase17
approved these changes
May 1, 2023
hwchase17
reviewed
May 1, 2023
hwchase17
added
the
lgtm
hwchase17
merged commit e2e0523
into
langchain-ai:harrison/azure-openai
5 of 9 checks passed
zioproto
added a commit
to zioproto/cheshire-cat
that referenced
this pull request
May 2, 2023
Do not use the Fake Embeddings anymore. Requires LangChain 0.0.155 because it contains langchain-ai/langchain#3711
zioproto
added a commit
to zioproto/cheshire-cat
that referenced
this pull request
May 2, 2023
Do not use the Fake Embeddings anymore. Requires LangChain 0.0.155 because it contains langchain-ai/langchain#3711
|
Related issue: #3992 It needs to allow headers as well as model_kwargs, no? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue #1560