Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Vwp/fix vectorstore typing #3851

Merged
merged 2 commits into from
Apr 30, 2023
Merged

Vwp/fix vectorstore typing #3851

merged 2 commits into from
Apr 30, 2023

Conversation

vowelparrot
Copy link
Contributor

No description provided.

stakes and others added 2 commits April 30, 2023 16:34
@stakes
fix typing for vectorstore tools (#3808)
ae915c4 
use BaseLanguageModel instead of BaseLLM in BaseVectorStoreTool,
VectorStoreToolkit, and VectorStoreRouterToolkit so chat models work

just like #2183 and #1807 before it!
@vowelparrot
Update imports
aa7412c
@vowelparrot vowelparrot merged commit b1d69d3 into master Apr 30, 2023
9 checks passed
@vowelparrot vowelparrot deleted the vwp/fix-vectorstore-typing branch April 30, 2023 23:45
samching pushed a commit to samching/langchain that referenced this pull request May 1, 2023
@vowelparrot @stakes @samching
Vwp/fix vectorstore typing (langchain-ai#3851)
bd95699 
Co-authored-by: Jay Stakelon <stakes@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@vowelparrot @stakes