Harrison/datetime parser #4693
Merged
Harrison/datetime parser #4693
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eyurtsev
reviewed
May 15, 2023
|
|
||
| def get_format_instructions(self) -> str: | ||
| examples = comma_list(_generate_random_datetime_strings(self.format)) | ||
| return f"""Write a datetime string that matches the |
There was a problem hiding this comment.
I wonder whether it makes sense to ask for an ISO-8601 format. No idea what llms handle :)
| from langchain.utils import comma_list | ||
|
|
||
|
|
||
| def _generate_random_datetime_strings( |
There was a problem hiding this comment.
Why is this not a hard-coded pattern or at least using a seed?
|
|
||
| # Test invalid input | ||
| try: | ||
| sleep(0.001) |
There was a problem hiding this comment.
we should use freeze gun here, should avoid sleep in tests at all costs
Co-authored-by: Eugene Yurtsev <eyurtsev@gmail.com>
vowelparrot
pushed a commit
that referenced
this pull request
May 31, 2023
Co-authored-by: Jacob Valdez <jacobfv@msn.com> Co-authored-by: Jacob Valdez <jacob.valdez@limboid.ai> Co-authored-by: Eugene Yurtsev <eyurtsev@gmail.com>
Merged
Undertone0809
pushed a commit
to Undertone0809/langchain
that referenced
this pull request
Jun 19, 2023
Co-authored-by: Jacob Valdez <jacobfv@msn.com> Co-authored-by: Jacob Valdez <jacob.valdez@limboid.ai> Co-authored-by: Eugene Yurtsev <eyurtsev@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.