Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update llamacpp demonstration notebook #5344

Merged

Conversation

sadaisystems
Copy link
Contributor

Update llamacpp demonstration notebook

Add instructions to install with BLAS backend, and update the example of model usage.

Fixes #5071. However, it is more like a prevention of similar issues in the future, not a fix, since there was no problem in the framework functionality

Who can review?

Community members can review the PR once tests pass. Tag maintainers/contributors who might be interested:

Copy link
Contributor

@hwchase17 hwchase17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is there anyplace we can just link to instead? as the underlying methods change, seems annoying to keep this up to date. would be nice to just link

@sadaisystems
Copy link
Contributor Author

sadaisystems commented May 28, 2023

is there anyplace we can just link to instead? as the underlying methods change, seems annoying to keep this up to date. would be nice to just link

As for the installation process, we can link directly to the installation manual inside the llama-cpp-python repository. I also included this link in the updated version of the notebook.

In case of API reference, we can link to the llama-cpp-python documentation API Reference section. As long as langchains' wrapper interface is aligned with this high-level API interface, it should be helpful enough. I could also include this link in the notebook with a warning about potential future changes.

Imo, this updated version of the notebook should be informative enough to cover basic user needs in the future, since it covers only the most important steps and parameters.

@hwchase17 hwchase17 merged commit f6615ca into langchain-ai:master May 29, 2023
13 checks passed
vowelparrot pushed a commit that referenced this pull request May 31, 2023
# Update llamacpp demonstration notebook

Add instructions to install with BLAS backend, and update the example of
model usage.

Fixes #5071. However, it is more like a prevention of similar issues in
the future, not a fix, since there was no problem in the framework
functionality

## Who can review?

Community members can review the PR once tests pass. Tag
maintainers/contributors who might be interested:

- @hwchase17 
- @agola11
@danielchalef danielchalef mentioned this pull request Jun 5, 2023
Undertone0809 pushed a commit to Undertone0809/langchain that referenced this pull request Jun 19, 2023
# Update llamacpp demonstration notebook

Add instructions to install with BLAS backend, and update the example of
model usage.

Fixes langchain-ai#5071. However, it is more like a prevention of similar issues in
the future, not a fix, since there was no problem in the framework
functionality

## Who can review?

Community members can review the PR once tests pass. Tag
maintainers/contributors who might be interested:

- @hwchase17 
- @agola11
This was referenced Jun 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Issue: LLamacpp wrapper slows down the model
2 participants