Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing comma in conv chat agent prompt json #5573

Merged
merged 1 commit into from Jun 1, 2023

Conversation

andrewlei
Copy link
Contributor

@andrewlei andrewlei commented Jun 1, 2023

Add missing comma in conversational chat agent prompt json

Inspired by: langchain-ai/langchainjs#1498

Before submitting

Who can review?

Community members can review the PR once tests pass. Tag maintainers/contributors who might be interested:
Agents / Tools / Toolkits

@andrewlei andrewlei changed the title Add missing comma in conv chat agent prompt Add missing comma in conv chat agent prompt json Jun 1, 2023
Copy link
Contributor

@vowelparrot vowelparrot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

@dev2049 dev2049 merged commit 6258f72 into langchain-ai:master Jun 1, 2023
12 checks passed
@andrewlei andrewlei deleted the fix-conv-chat-agent-json branch June 1, 2023 20:15
@danielchalef danielchalef mentioned this pull request Jun 5, 2023
Undertone0809 pushed a commit to Undertone0809/langchain that referenced this pull request Jun 19, 2023
# Add missing comma in conversational chat agent prompt json

Inspired by: langchain-ai/langchainjs#1498
This was referenced Jun 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants