Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

human approval callback #5581

Merged
merged 4 commits into from Jun 2, 2023
Merged

human approval callback #5581

merged 4 commits into from Jun 2, 2023

Conversation

dev2049
Copy link
Contributor

@dev2049 dev2049 commented Jun 1, 2023

Screenshot 2023-06-01 at 2 39 40 PM

@dev2049
Copy link
Contributor Author

dev2049 commented Jun 1, 2023 •
edited

could alternatively try implementing this through existing ToolInputSchema approach but seemed harder to make that modular / easy to pass around to every diff tool

@dev2049 dev2049 requested a review from vowelparrot June 1, 2023 21:43
agola11
agola11 reviewed Jun 2, 2023
View reviewed changes
Copy link
Collaborator

@agola11 agola11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, I've been thinking about making it possible to raise exceptions for certain handlers and not catch them, this looks like a good use case for that

@dev2049 dev2049 changed the title RFC: human approval callback human approval callback Jun 2, 2023
@dev2049 dev2049 merged commit 8b3df18 into master Jun 2, 2023
13 checks passed
@dev2049 dev2049 deleted the dev2049/human_approval_callback branch June 2, 2023 13:59
@danielchalef danielchalef mentioned this pull request Jun 5, 2023
Merged
Undertone0809 pushed a commit to Undertone0809/langchain that referenced this pull request Jun 19, 2023
@dev2049 @Undertone0809
human approval callback (langchain-ai#5581)
40ba2ea 
![Screenshot 2023-06-01 at 2 39 40
PM](https://github.com/hwchase17/langchain/assets/130488702/769f1480-7e51-46d9-bcde-698d0b091803)
This was referenced Jun 25, 2023
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@agola11 agola11 agola11 left review comments

@nfcampos nfcampos Awaiting requested review from nfcampos

@hwchase17 hwchase17 Awaiting requested review from hwchase17

@vowelparrot vowelparrot Awaiting requested review from vowelparrot

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@dev2049 @agola11