fix markdown text splitter horizontal lines #5625
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@devstein, I appreciate your suggestion, but using re.escape would also escape the '' character in '\n', which isn't the intended behavior. It's important to note that these strings are regular expressions, so they should be explicitly defined for the sake of clarity and to better comprehend their functionality. |
IlyaMichlin
changed the title
|
@hwchase17 I added a test for markdown. |
hwchase17
added
the
lgtm
Undertone0809
pushed a commit
to Undertone0809/langchain
that referenced
this pull request
Jun 19, 2023
Fixes langchain-ai#5614 #### Issue The `***` combination produces an exception when used as a seperator in `re.split`. Instead `\*\*\*` should be used for regex exprations. #### Who can review? @eyurtsev
kacperlukawski
pushed a commit
to kacperlukawski/langchain
that referenced
this pull request
Jun 29, 2023
Fixes langchain-ai#5614 #### Issue The `***` combination produces an exception when used as a seperator in `re.split`. Instead `\*\*\*` should be used for regex exprations. #### Who can review? @eyurtsev
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5614
Issue
The
***combination produces an exception when used as a seperator inre.split. Instead\*\*\*should be used for regex exprations.Who can review?
@eyurtsev