support returning run info for llms, chat models and chains #5666
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nfcampos
reviewed
Jun 4, 2023
| @@ -108,6 +108,8 @@ def __call__( | |||
| inputs: Union[Dict[str, Any], Any], | |||
| return_only_outputs: bool = False, | |||
| callbacks: Callbacks = None, | |||
| *, | |||
| include_run_info: bool = False, | |||
There was a problem hiding this comment.
Mainly for better bw-compat, we have a bunch of existing tests that check the returned dict from __call__ and expect it not to have a __run field. Other people might have tests like that too.
nfcampos
reviewed
Jun 4, 2023
| @@ -93,6 +94,8 @@ def generate( | |||
| generations = [res.generations for res in results] | |||
| output = LLMResult(generations=generations, llm_output=llm_output) | |||
| run_manager.on_llm_end(output) | |||
| if run_manager: | |||
| output.run = RunInfo(run_id=run_manager.run_id) | |||
There was a problem hiding this comment.
unfortunately you cannot set underscore keys in pydantic objects, i.e. LLMResult
There was a problem hiding this comment.
Wow these python libraries are something else
There was a problem hiding this comment.
Could set the alias then serialize with by_alias=True though maybe that's even more complicated
There was a problem hiding this comment.
yeah... seems more complex than it needs to imo
Undertone0809
pushed a commit
to Undertone0809/langchain
that referenced
this pull request
Jun 19, 2023
…n-ai#5666) returning the run id is important for accessing the run later on
kacperlukawski
pushed a commit
to kacperlukawski/langchain
that referenced
this pull request
Jun 29, 2023
…n-ai#5666) returning the run id is important for accessing the run later on
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
returning the run id is important for accessing the run later on