Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Base RunEvaluator Chain #5750

Merged
merged 5 commits into from
Jun 6, 2023
Merged

Base RunEvaluator Chain #5750

merged 5 commits into from
Jun 6, 2023

Conversation

vowelparrot
Copy link
Contributor

@vowelparrot vowelparrot commented Jun 5, 2023

Clean up a bit and only implement the QA and reference free implementations from #5618

@vowelparrot vowelparrot force-pushed the vwp/evaluator_chain_base branch 3 times, most recently from b4fc0e3 to 9ce74cd Compare June 5, 2023 20:46
Copy link
Collaborator

@agola11 agola11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have a few questions about class hierarchy and how this relates to the sdk but we can chat tmrw. Otherwise looks good

return self.parse(text)


class RunEvaluator(Chain):
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

won't this clash with RunEvaluator from the sdk? Also most (all?) subclasses of Chain end with Chain, i.e. RunEvaluatorChain

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually I'm a bit confused here. Should this just be a subclass of langchainplus_sdk.evaluation.evaluator.RunEvaluator? It implements evaluate_run

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It should! my oversight - will rename and inherit

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems like there are a ton of errors in this notebook. Is this expected? Also, should we move this out of experimental?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can use da Vinci instead - I think previously the model hallucinated but a recent push made them parsing errors

feedback = self.output_parser.parse_chain_output(chain_output)
return {"feedback": feedback}

def evaluate_run(
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

having async support might be important here so we can run evals faster/concurrently

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ya I agree

Base automatically changed from vwp/invert to master June 6, 2023 13:51
@vowelparrot vowelparrot force-pushed the vwp/evaluator_chain_base branch 3 times, most recently from 4bf985f to 658cae0 Compare June 6, 2023 22:18
@vowelparrot vowelparrot merged commit 217b5cc into master Jun 6, 2023
12 checks passed
@vowelparrot vowelparrot deleted the vwp/evaluator_chain_base branch June 6, 2023 23:42
Undertone0809 pushed a commit to Undertone0809/langchain that referenced this pull request Jun 19, 2023
Clean up a bit and only implement the QA and reference free
implementations from langchain-ai#5618
This was referenced Jun 25, 2023
kacperlukawski pushed a commit to kacperlukawski/langchain that referenced this pull request Jun 29, 2023
Clean up a bit and only implement the QA and reference free
implementations from langchain-ai#5618
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants