feat: Wolfram alpha tool #578
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…angchain into wolfram-alpha-tool
bborn
reviewed
Jan 11, 2023
| def run(self, query: str) -> str: | ||
| """Run query through WolframAlpha and parse result.""" | ||
| res = self.wolfram_client.query(query) | ||
| # Includes only text from the response |
There was a problem hiding this comment.
@nickscamara can we return more from the Wolfram response (e.g. the units of the answer)? For example, if you run a query like "How big is the moon?" via LangChain's wrapper, you get back "1079.6", and then LangChain will return "The moon is 1079.6 miles in diameter.", which is incorrect - 1079.6 is actually the radius, not the diameter.
I'm assuming the Wolfram response included that, but it was just dropped by the wrapper?
There was a problem hiding this comment.
Thank you for that! #584 should now include the assumption.
nickscamara
added a commit
to nickscamara/langchain
that referenced
this pull request
Jan 11, 2023
nickscamara
added a commit
to nickscamara/langchain
that referenced
this pull request
Jan 11, 2023
hwchase17
pushed a commit
that referenced
this pull request
Jan 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue linked with: #455
Added Wolfram Alpha as a tool.