Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set Falsey #5783

Merged
merged 1 commit into from
Jun 6, 2023
Merged

Set Falsey #5783

merged 1 commit into from
Jun 6, 2023

Conversation

vowelparrot
Copy link
Contributor

@vowelparrot vowelparrot commented Jun 6, 2023

Seems natural to try to disable logging by setting MY_VAR=false rather than unsetting (especially once you've already set it in the background)

Copy link
Contributor

@hwchase17 hwchase17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dnake

@hwchase17 hwchase17 merged commit 0cfaa76 into master Jun 6, 2023
12 checks passed
@hwchase17 hwchase17 deleted the vwp/false branch June 6, 2023 16:26
Undertone0809 pushed a commit to Undertone0809/langchain that referenced this pull request Jun 19, 2023
Seems natural to try to disable logging by setting `MY_VAR=false` rather
than unsetting (especially once you've already set it in the background)
This was referenced Jun 25, 2023
kacperlukawski pushed a commit to kacperlukawski/langchain that referenced this pull request Jun 29, 2023
Seems natural to try to disable logging by setting `MY_VAR=false` rather
than unsetting (especially once you've already set it in the background)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants