Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add UTF-8 json ouput support while langchain.debug is set to True. #5802

Merged
merged 1 commit into from
Jun 7, 2023
Merged

Add UTF-8 json ouput support while langchain.debug is set to True. #5802

merged 1 commit into from
Jun 7, 2023

Conversation

boxcounter
Copy link
Contributor

@boxcounter boxcounter commented Jun 7, 2023 •
edited

Before:
image

After:
image

Thanks in advance.

@agola11

@boxcounter boxcounter changed the title Update stdout.py to set ensure_ascii=False in try_json_stringify func… Add UTF-8 json ouput support while langchain.debug is set to True. Jun 7, 2023
hwchase17
hwchase17 approved these changes Jun 7, 2023
View reviewed changes
Copy link
Contributor

@hwchase17 hwchase17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems reasonable! thanks

@hwchase17 hwchase17 added the lgtm PR looks good. Use to confirm that a PR is ready for merging. label Jun 7, 2023
@hwchase17 hwchase17 merged commit b7999a9 into langchain-ai:master Jun 7, 2023
12 checks passed
Undertone0809 pushed a commit to Undertone0809/langchain that referenced this pull request Jun 19, 2023
@boxcounter @Undertone0809
Add UTF-8 json ouput support while langchain.debug is set to True. (l…
a09314e 
…angchain-ai#5802)

Before:
<img width="984" alt="image"
src="https://github.com/hwchase17/langchain/assets/4317474/2b0807b4-a1d6-4df2-87cc-92b1c8e10534">

After:
<img width="992" alt="image"
src="https://github.com/hwchase17/langchain/assets/4317474/128c2c7d-2ed5-4c95-954d-b0964c83526a">


Thanks in advance.

 @agola11
This was referenced Jun 25, 2023
Closed
Merged
kacperlukawski pushed a commit to kacperlukawski/langchain that referenced this pull request Jun 29, 2023
@boxcounter @kacperlukawski
Add UTF-8 json ouput support while langchain.debug is set to True. (l…
df17c72 
…angchain-ai#5802)

Before:
<img width="984" alt="image"
src="https://github.com/hwchase17/langchain/assets/4317474/2b0807b4-a1d6-4df2-87cc-92b1c8e10534">

After:
<img width="992" alt="image"
src="https://github.com/hwchase17/langchain/assets/4317474/128c2c7d-2ed5-4c95-954d-b0964c83526a">


Thanks in advance.

 @agola11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hwchase17 hwchase17 hwchase17 approved these changes

Assignees
No one assigned
Labels
lgtm PR looks good. Use to confirm that a PR is ready for merging.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@boxcounter @hwchase17