Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HuggingFaceEndpoint incorrectly assumes that the endpoint returns the prompt prepended to the response #7503

Closed
wants to merge 1 commit into from
Closed

HuggingFaceEndpoint incorrectly assumes that the endpoint returns the prompt prepended to the response #7503

wants to merge 1 commit into from

Conversation

juananpe
Copy link

  • Description: HuggingFaceEndpoint truncates the text because it assumes the endpoint returns the prompt together with generated text (but that's not the case, so the the code wrongly truncates the answer)
  • Issue: Fixes HuggingFaceEndpoint Class Bug #7353
  • Dependencies: None
  • Tag maintainer: @baskaryan
  • Twitter handle: @juanan

This issue has also been discussed here:
https://huggingface.co/tiiuae/falcon-40b-instruct/discussions/51

@vercel
Copy link

vercel bot commented Jul 10, 2023 •
edited

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
langchain ⬜️ Ignored (Inspect) Jul 10, 2023 10:12pm

@dosubot dosubot bot added the 🤖:bug Related to a bug, vulnerability, unexpected error with an existing feature label Jul 10, 2023
@HashemAlsaket
Copy link
Contributor

#7386

@juananpe juananpe closed this Jul 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
🤖:bug Related to a bug, vulnerability, unexpected error with an existing feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

HuggingFaceEndpoint Class Bug
2 participants
@juananpe @HashemAlsaket