Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Faiss-node has a hidden dependency on libomp, causes unit tests to fail on some machines #1383

Closed
jacoblee93 opened this issue May 23, 2023 · 2 comments · Fixed by ewfian/faiss-node#5 or #1420
Closed

Faiss-node has a hidden dependency on libomp, causes unit tests to fail on some machines #1383

jacoblee93 opened this issue May 23, 2023 · 2 comments · Fixed by ewfian/faiss-node#5 or #1420
Assignees
@ewfian

Comments

@jacoblee93
Copy link
Collaborator

jacoblee93 commented May 23, 2023 •
edited

Introduced in #685, will change unit tests to integration tests to signify the need for more setup. Ideally this would be bundled in or the dependency would somehow otherwise be represented in the future.
@jacoblee93 jacoblee93 mentioned this issue May 23, 2023
Merged
@ewfian
Copy link
Contributor

ewfian commented May 24, 2023

@jacoblee93 I'll fix it on the faiss-node side by bundling libomp. Please assign this issue to me.

@jacoblee93
Copy link
Collaborator Author

Oh awesome! Will do.

This was referenced May 24, 2023
Merged
Merged
jacoblee93 pushed a commit that referenced this issue May 26, 2023
@ewfian
fix: #1383 update faiss-node to avoid libomp missing (#1420)
70ac7c4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ewfian ewfian

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

bundle the libomp ewfian/faiss-node
fix: #1383 update faiss-node to avoid libomp missing
2 participants
@jacoblee93 @ewfian