Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to Use a Factory Method #1250

Merged
merged 1 commit into from May 15, 2023
Merged

Update to Use a Factory Method #1250

merged 1 commit into from May 15, 2023

Conversation

vowelparrot
Copy link
Contributor

To enable independent trials over datasets

@vercel
Copy link

vercel bot commented May 12, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
langchainjs-docs ✅ Ready (Inspect) Visit Preview May 15, 2023 4:46pm

return (
typeof bch?._chainType === "function" && bch?._chainType() !== undefined
);
}

type _ModelType = "llm" | "chatModel" | "chainFactory";

async function getModelOrFactoryType(
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Extracted this to avoid instantiating multiple times just to check type

To enable independent trials over datasets
@vowelparrot vowelparrot requested a review from nfcampos May 15, 2023 16:36
@vowelparrot vowelparrot merged commit bb60f47 into main May 15, 2023
10 checks passed
@vowelparrot vowelparrot deleted the vwp/client_factory branch May 15, 2023 23:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant