Fix env detection for Deno in Supabase Edge Functions #1298
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
dqbd
force-pushed
the
supabase-env-detection
branch
from
992abeb
to
4f20f16
Compare
dqbd
commented
May 17, 2023
| export const isDeno = () => typeof Deno !== "undefined"; | ||
|
|
||
| // Mark not-as-node if in Supabase Edge Function | ||
| export const isNode = () => |
There was a problem hiding this comment.
Have tried using /* #__PURE__*/, but without much luck
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1268
It does seem like Supabase Deno Functions only provides a global Deno functions without
versionsproperty, which will markisDenoasfalseand because of NodeJS compat, will markisNodeastrue.This PR aims to correct both of the properties, which is required to force the
axios-fetch-adapterin these environments.