Add support for memoryPrompts in StructuredChatAgent #1347
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
andrewlei
changed the title
andrewlei
changed the title
|
We'd love to support memory in this agent, but the ideal implementation would probably look more like this: https://github.com/hwchase17/langchainjs/blob/main/langchain/src/agents/chat_convo/index.ts For this use-case, I'd suggest just passing a custom |
|
Seems like I was presumptive in closing this as it's what Python's implemented - reopening! Apologies for the confusion. |
|
GH-1414 is another attempt at providing memory support for this agent that is closer in spirit to the rest of ts codebase. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
memoryPromptsinStructuredChatAgent, inspired by python library: https://github.com/hwchase17/langchain/blob/master/langchain/agents/structured_chat/base.py#L94inputVariablesprovided byStructuredChatCreatePromptArgs