-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add Momento as a standard cache and chat history provider #1416
Merged
jacoblee93
merged 11 commits into
langchain-ai:main
from
malandis:feat/add-momento-cache
May 30, 2023
Merged
feat: add Momento as a standard cache and chat history provider #1416
jacoblee93
merged 11 commits into
langchain-ai:main
from
malandis:feat/add-momento-cache
May 30, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Because I'm Using nodenv with multiple node versions installed, we use the node local to specify the version to use in a particular repo.
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
We make appropriate fields readonly.
jacoblee93
reviewed
May 29, 2023
jacoblee93
reviewed
May 29, 2023
jacoblee93
requested changes
May 29, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good overall, a few comments.
jacoblee93
added
question
Further information is requested
close
PRs that need one or two touch-ups to be ready
labels
May 29, 2023
Previously both the Momento cache module and Momento chat history modules had a `ensureCacheExists` function, which were identical. This commit extracts the function to a single place in a utility module.
jacoblee93
added
lgtm
PRs that are ready to be merged as-is
and removed
question
Further information is requested
close
PRs that need one or two touch-ups to be ready
labels
May 29, 2023
Thank you! Will merge this with the next release tomorrow. |
jacoblee93
approved these changes
May 29, 2023
Wonderful! For Twitter attribution please use @momentohq |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add Momento as a standard cache and chat message history provider
This PR adds Momento as a standard caching provider. Implements the interface, adds integration tests, and documentation. We also add Momento as a chat history message provider along with integration tests, and documentation.
Momento is a fully serverless cache. Similar to S3 or DynamoDB, it requires zero configuration, infrastructure management, and is instantly available. Users sign up for free and get 50GB of data in/out for free every month.
Before submitting
✅ We have added documentation, notebooks, and integration tests demonstrating usage. We verified the docs build and render correctly. We also ran the examples locally.