Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: #1383 update faiss-node to avoid libomp missing #1420

Merged
merged 1 commit into from May 26, 2023
Merged

fix: #1383 update faiss-node to avoid libomp missing #1420

merged 1 commit into from May 26, 2023

Conversation

ewfian
Copy link
Contributor

@ewfian ewfian commented May 26, 2023

Update faiss-node to avoid libomp missing

  • Update faiss-node.
  • Revert faiss_simple.int.test.ts to a unit test.
  • Remove libomp installation info from docs.

Fixes #1383

@vercel
Copy link

vercel bot commented May 26, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
langchainjs-docs ✅ Ready (Inspect) Visit Preview May 26, 2023 0:06am

@jacoblee93
Copy link
Collaborator

Thank you!

@jacoblee93 jacoblee93 self-assigned this May 26, 2023
@jacoblee93 jacoblee93 added the lgtm PRs that are ready to be merged as-is label May 26, 2023
@jacoblee93 jacoblee93 merged commit 70ac7c4 into langchain-ai:main May 26, 2023
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm PRs that are ready to be merged as-is
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Faiss-node has a hidden dependency on libomp, causes unit tests to fail on some machines
2 participants