Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Include placeholder value for all secrets used, not just those in kwargs #1696

Merged
merged 4 commits into from Jun 19, 2023
Merged

Include placeholder value for all secrets used, not just those in kwargs #1696

merged 4 commits into from Jun 19, 2023

Conversation

nfcampos
Copy link
Collaborator

Fixes # (issue)

@vercel
Copy link

vercel bot commented Jun 19, 2023 •
edited

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
langchainjs-docs ✅ Ready (Inspect) Visit Preview Jun 19, 2023 2:34pm

dqbd
dqbd reviewed Jun 19, 2023
View reviewed changes
Copy link
Collaborator

@dqbd dqbd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

langchain/src/chat_models/openai.ts Show resolved Hide resolved
dqbd

This comment was marked as duplicate.

Sign in to view

@dqbd dqbd mentioned this pull request Jun 19, 2023
Merged
@nfcampos
Fix test
dae3a04
@nfcampos
Fix test
3e30fe8
@nfcampos
Add error handling for openai streaming when errors are sent as event…
538a0ca 
…s in the SSE stream (#1698)

* Add error handling for openai streaming when errors are sent as events in the SSE stream

* Lint
@nfcampos nfcampos merged commit 276fd1c into main Jun 19, 2023
10 checks passed
@nfcampos nfcampos deleted the nc/serde-include-sentinel-used-secrets branch June 19, 2023 14:41
nfcampos pushed a commit to langchain-ai/langchain that referenced this pull request Jun 19, 2023
@dqbd
Include placeholder value for all secrets, not just kwargs (#6421)
be9371c 
Mirror PR for langchain-ai/langchainjs#1696

Secrets passed via environment variables should be present in the
serialised chain
kacperlukawski pushed a commit to kacperlukawski/langchain that referenced this pull request Jun 29, 2023
@dqbd @kacperlukawski
Include placeholder value for all secrets, not just kwargs (langchain…
e599ac6 
…-ai#6421)

Mirror PR for langchain-ai/langchainjs#1696

Secrets passed via environment variables should be present in the
serialised chain
@CWXDEV CWXDEV mentioned this pull request Jun 30, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dqbd dqbd dqbd left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@nfcampos @dqbd