New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable support for Browsers, Cloudflare Workers, Next.js Browser/Serverless/Edge #632
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
6e05014
to
309027b
Compare
4738998
to
180de53
Compare
this is very exciting |
I am hyped about this. Still have problems with streaming, this might be huge step forward. :) |
05088f4
to
1464380
Compare
+1, i will test w/ the lex-gpt app (https://lex-gpt.vercel.app/) as soon as this goes in :) |
@PineappleExpress808 Any updates? Is it working and if so let us know of any roadblocks ahead. |
i haven't tested. will wait for this PR to go in and a new release is cut. Vercel mentioned that streaming will work if: or 2/ users migrate Vercel apps to use route handlers (https://beta.nextjs.org/docs/routing/route-handlers) in any case, i'll definitely test w/ this update. |
b78d9e4
to
3999b76
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From my perspective (mostly looking at import refactoring) looks good! Thanks!
}); | ||
|
||
// Run the chain but don't await it | ||
chain.run("hello").catch(console.error); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why don't we await here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Because we need the response to start being sent to the user right away. If we await then we'll only start sending response after the chain run finishes, therefore no streaming
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why do we need this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Because there was some packaging issue with the dependency we were using for this and it was easiest to include a copy here. Same licence as we have
entryPoint = { | ||
node: entryPoint, | ||
}; | ||
} else if (fs.existsSync(litePath)) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah should probably remove
789391b
to
dce825d
Compare
- [ ] Split File loaders from Blob loaders (File loaders remain with the existing name, Blob loaders are new)Will tackle later in #663Cannot find module '@fortaine/fetch-event-source/parse' from '../langchain/dist/util/axios-fetch-adapter.js'
replace with eventsource-parser ?create-react-app
template