Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove requirement for cards to have both term and definition filled in #153

Open
ahmadshariq711 opened this issue Apr 25, 2024 · 4 comments
Labels
enhancement New feature or request upcoming feature This feature has been accepted and will be worked on

Comments

@ahmadshariq711
Copy link

When creating flashcards, and both term and definition is empty, the save button doesn't work. A red alert shows up, on the flashcard with the issue, but it would be better if the alert also shows up on top near the save button to increase user-friendliness.

image
This is the empty flashcard before saving
image
This is after clicking the save button
image
It would be better to also have an alert message near the save button as the flashcard that is empty may not be visible

@hwgilbert16 hwgilbert16 added enhancement New feature or request upcoming feature This feature has been accepted and will be worked on labels Apr 26, 2024
@hwgilbert16
Copy link
Owner

I'll see if I can get the page to scroll to the first card with missing fields. If not, an alert up the top can be added.

@ahmadshariq711
Copy link
Author

Thank you!

@BrianENguyen
Copy link

If possible, it would be a lot better if you removed the requirement to have non-blank cards in a study set. It gets very tedious when saving a set, only to find out that there's a blank card. This would make me continuously scroll the page until I find it. Quizlet doesn't have non-blank cards requirement

@hwgilbert16
Copy link
Owner

If possible, it would be a lot better if you removed the requirement to have non-blank cards in a study set. It gets very tedious when saving a set, only to find out that there's a blank card. This would make me continuously scroll the page until I find it. Quizlet doesn't have non-blank cards requirement

Good point. Initially, I was concerned about blank cards being a potential DOS attack vector. However, with the current ratelimiting that is in place, this is not a possibility.

This requirement will be removed in the next release.

@hwgilbert16 hwgilbert16 changed the title Creating Empty Flashcards causes issue with saving Remove requirement for cards to have both term and definition filled in May 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request upcoming feature This feature has been accepted and will be worked on
Projects
None yet
Development

No branches or pull requests

3 participants