Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cascading card updates and API isolation #54

Closed
5 tasks done
hwgilbert16 opened this issue Sep 11, 2023 · 0 comments · Fixed by #108
Closed
5 tasks done

Cascading card updates and API isolation #54

hwgilbert16 opened this issue Sep 11, 2023 · 0 comments · Fixed by #108
Labels
upcoming feature This feature has been accepted and will be worked on
Milestone

Comments

@hwgilbert16
Copy link
Owner

hwgilbert16 commented Sep 11, 2023

Currently, existing knowledge of the structure of a set is needed to accurately update cards without breaking the ordering.

The primary method of adding cards should be via the /cards route instead of recreating every card in a set every time a single card needs to be updated.

Adding and updating cards should be relatively plug and play too. Indexes should not be able to be overwritten, there shouldn't be gaps in it, etc.

  • When updating or creating a card, if the index already exists, the card should be placed at the desired index, and the conflicting one pushed up -
  • When updating or creating a card, if the index is greater than the bottommost existing card, the new card should be one more than the bottommost
  • It should no longer be possible to update every card in a set via the sets controller. The cards controller should be used instead. Will leave this as an option for API users, but frontend will use more efficient method.
  • Cards controller should be nested under /sets/cards for clarity. Leitner cards should receive their own controller too and be nested under /leitner-sets/cards to show the relations between these two.
  • When editing a set, after saving, every single card component should not be recreated. This can be incredibly laggy on low-powered computers.
@hwgilbert16 hwgilbert16 added the upcoming feature This feature has been accepted and will be worked on label Sep 11, 2023
@hwgilbert16 hwgilbert16 modified the milestones: v1.1.1, v1.2.0 Jan 16, 2024
@hwgilbert16 hwgilbert16 linked a pull request Feb 14, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
upcoming feature This feature has been accepted and will be worked on
Projects
Development

Successfully merging a pull request may close this issue.

1 participant