Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable usage of custom UserCheckers #1358

Closed
simivar opened this issue Mar 20, 2018 · 7 comments
Closed

Enable usage of custom UserCheckers #1358

simivar opened this issue Mar 20, 2018 · 7 comments

Comments

@simivar
Copy link
Contributor

simivar commented Mar 20, 2018

HWIOAuthBundle always uses UserChecker provided by Symfony Security Component with alias hwi_oauth.user_checker.

Currently I'm using HWIOAuthBundle with FOSUserBundle to allow Facebook login. I started working on ability to ban users and added custom user checker which checks whether user is banned or no. Right now it does not work because of said issue.

Fix from FOSUserBundle is available here.

Any fix available?

@fcaraballo
Copy link

Same issue here!

@XWB
Copy link
Member

XWB commented Jun 13, 2018

Do you mean that hwi_oauth.user_checker should alias to the custom user checker (if available)?

@simivar
Copy link
Contributor Author

simivar commented Jun 13, 2018

@XWB Yes.

@XWB
Copy link
Member

XWB commented Jun 13, 2018

The issue is that you can have multiple firewalls, while FOSUserBundle uses just one firewall.

security:
    firewalls:
        main:
            user_checker: App\Security\UserChecker1
        second:
            user_checker: App\Security\UserChecker2

In this case, hwi_oauth.user_checker cannot alias to both user checkers.

@simivar
Copy link
Contributor Author

simivar commented Jun 16, 2018

Maybe it would be a good idea to use alias to custom user checker by default and throw an Exception when there are many?

Copy link

Message to comment on stale issues. If none provided, will not mark issues stale

@github-actions github-actions bot added the Stale label Feb 25, 2024
Copy link

github-actions bot commented Mar 1, 2024

This issue was closed because it has been stalled for 5 days with no activity.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Mar 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants