Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should promisified function return rejected promise when done is not called, but returns a non Promise value #20

Closed
tunnckoCore opened this issue Apr 4, 2017 · 0 comments
Labels

Comments

@tunnckoCore
Copy link
Member

e.g.

var fn = redolent(function (done) {
  return 'foo bar'
})

fn().catch(function (err) {
  console.log(err)
})

It can only return a Promise or undefined, or call the callback.

in these cases it not rejects

var fn = redolent(function (done) {
  return
})

var fn = redolent(function (done) {
  return undefined
})
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant