Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

code and test contains data race #1017

Closed
gen2thomas opened this issue Oct 27, 2023 · 2 comments
Closed

code and test contains data race #1017

gen2thomas opened this issue Oct 27, 2023 · 2 comments

Comments

@gen2thomas
Copy link
Collaborator

run tests with race, e.g. by make test_race gives multiple data race errors

  • fix those errors
  • add some remarks to documentation for new contributors
  • maybe activate "-race" flag by default
  • maybe add remark to PR template
@gen2thomas gen2thomas self-assigned this Oct 27, 2023
@gen2thomas gen2thomas added enhancement documentation-needed in work the implementation or bug fix is in work by developers labels Oct 27, 2023
@gen2thomas gen2thomas changed the title test contains data race code and test contains data race Oct 30, 2023
@gen2thomas
Copy link
Collaborator Author

gen2thomas commented Oct 30, 2023

  • aio
  • gpio
  • system/i2c_device.go (maybe a GC problem with syscall uintptr) --> affects i2c drivers and all adaptors, which support i2c
  • test of ollie driver
  • documentation

@gen2thomas gen2thomas added done on dev the feature or bug is solved on dev branch and wait for merge to release branch and removed in work the implementation or bug fix is in work by developers labels Nov 11, 2023
@gen2thomas
Copy link
Collaborator Author

fix released with v2.3.0

@gen2thomas gen2thomas removed the done on dev the feature or bug is solved on dev branch and wait for merge to release branch label Jan 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant