Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ReactionAdd event ignores old messages even if the bot is running on a bot account #1675

Closed
1 task done
meldsza opened this issue Jul 10, 2017 · 5 comments
Closed
1 task done

Comments

@meldsza
Copy link

meldsza commented Jul 10, 2017

The code at
https://github.com/hydrabolt/discord.js/blob/master/src/client/actions/MessageReactionAdd.js
Ignores messages that haven't been already cached. So if I want to listen to message reactions that were sent before my not restarted, I would not be able to.

Further details:

  • discord.js version: master
  • node.js version: 7.8
  • Operating system: CentOs
  • Priority: 5/10

I found this issue while running code on a bot account

  • I have also tested the issue on latest master, commit hash:
@dragonfire535
Copy link
Contributor

Indeed, you will have to fetch any messages not in cache for events to fire.

@Drahcirius
Copy link
Member

Drahcirius commented Jul 10, 2017

This is currently the expected behaviour, #1376 is on the roadmap for v12, which will allow you to receive previously uncached reaction events with a client setting.

@meldsza
Copy link
Author

meldsza commented Jul 10, 2017

Is there a separate branch for v12 i can contribute to?

@Drahcirius
Copy link
Member

Master branch is v12. Contributions are welcome, but I will be submitting a PR for it soon.

@iCrawl
Copy link
Member

iCrawl commented Aug 1, 2017

Duplicate of #1376

@iCrawl iCrawl marked this as a duplicate of #1376 Aug 1, 2017
@iCrawl iCrawl closed this as completed Aug 1, 2017
@iCrawl iCrawl added s: duplicate and removed p: low labels Aug 1, 2017
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 7, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants