Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Duplicate Filter Hover Window changes next click on image to shift-click #384

Closed
Aegis43615 opened this issue Jul 13, 2020 · 1 comment
Closed
Labels
bug dev-notified HyDev has been notified of this

Comments

@Aegis43615
Copy link

Environment

Hydrus version: 403 executable
Platform: Windows
OS specifics: Win x64 10 Pro 1909

What happens

It seems that now in the duplicate filter, if you click anywhere on the hover window (that has all the buttons to skip, set 'this is better', stop, etc) it will make the first click you do back on the image act like a shift-click (which my left-shift-click pans the image, while the right-shift-click will do nothing). The second click after this will work as intended.

Steps to reproduce

1.Launch the duplicate filter having at least 1 potential duplicate pair
2.Click anywhere on the hover-window (either on the pane or on a button)
3.Click (and/or drag) the image or the background to try to use a filtering mouse shortcut
4.Note that you are just panning the image instead of setting a relation

Desired outcome

Clicking the mouse will do the selected filtering shortcut. Ex: Left click will set 'this is better' instead of doing the equivalent of a shift-click and just panning the image

@Aegis43615 Aegis43615 added the bug label Jul 13, 2020
@hydrusnetwork hydrusnetwork added the dev-notified HyDev has been notified of this label Jul 18, 2020
@hydrusnetwork
Copy link
Owner

Thank you, this should be fixed in tomorrow's 407.

This was an issue with the duplicate hover not being one that hides. On the other hovers, when you mouse the mouse off, they hide, and active focus moves to the media viewer.

With the dupe filter, the click off counts as a 'window-activating' click, which the shortcut system ignores. The mouse dragging seems to be activating quietly in the background, as some of this is still hard-coded when no other shortcut is caught. I have made it so mousing off a hover window immediately activates the media window, so no activating-click happens when coming off a hover window. Let me know if you have any more trouble with this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug dev-notified HyDev has been notified of this
Projects
None yet
Development

No branches or pull requests

2 participants