Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HydrusPaths.MergeFile() does not guard against metadata timestamp like HydrusPaths.MirrorFile() #989

Closed
bbappserver opened this issue Oct 17, 2021 · 1 comment

Comments

@bbappserver
Copy link
Contributor

https://github.com/hydrusnetwork/hydrus/blob/18517d8a73b7fecaa7a5c8dcf61d30ccbfcb9b51/hydrus/core/HydrusPaths.py#L649`
https://docs.python.org/3/library/shutil.html#shutil.move

As of python 3.5 shutil.move() will fallback to copy_function when traversing volumes which defaults to copy2().
HydrusPaths.MergeFile() calls shutil.move(), but does not specify a copy_function so copy2 is always used if crossing a volumes. This differs from how MirrorFile() works as it checks against timestamps and chooses an appropriate copy function for windows.

@hydrusnetwork
Copy link
Owner

Thank you for this report. This is fixed for this week's release!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants