Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

takeSnapshot not working on typescript, An argument for 'control' was not provided. #31

Closed
ramishenouda opened this issue Sep 27, 2021 · 3 comments
Closed

takeSnapshot not working on typescript, An argument for 'control' was not provided. #31

ramishenouda opened this issue Sep 27, 2021 · 3 comments
Labels
bug

Comments

@ramishenouda
Copy link

image
I'm getting the error when trying to compile my project from typescript to javascript
I'm using v8-profiler-next version "1.4.2"
my node version is 14.0.0
@hyj1991 hyj1991 mentioned this issue Sep 27, 2021
Merged
@hyj1991
Copy link
Owner

hyj1991 commented Sep 27, 2021

Sorry for this mistake, could you try #32 to see if it solves this issue.

If it did, I will release a new version :)

@ramishenouda
Copy link
Author

ramishenouda commented Sep 27, 2021 •
edited

this fixes the issues :D thank you for the fast response!

@hyj1991
Copy link
Owner

hyj1991 commented Sep 27, 2021 •
edited

Landed in d5006be (v8-profiler-next@v1.4.3).

@hyj1991 hyj1991 added the bug label May 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@hyj1991 @ramishenouda