Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make hash verification return True or False #150

Closed
tkbstudios opened this issue Aug 10, 2023 · 4 comments
Closed

Make hash verification return True or False #150

tkbstudios opened this issue Aug 10, 2023 · 4 comments

Comments

@tkbstudios
Copy link

Maybe make the hash verify function return True or False, and rasie an exception if there was an exception

@hynek
Copy link
Owner

hynek commented Aug 10, 2023

You don't think it would be a problem if suddenly argon2-cffi would suddenly accept all passwords under the old API contract?

@tkbstudios
Copy link
Author

no like if the hash is correct, return True, if it isn't return False and raise an exception if there was an exception

@hynek
Copy link
Owner

hynek commented Aug 10, 2023

Yes and there's 10 million downloads per month right now that expect an exception on a wrong password.

The reason why we raise an exception is in the FAQ and we can't change that anymore. If it bothers you so much, you can write a simple wrapper around the method.

@hynek hynek closed this as not planned Won't fix, can't repro, duplicate, stale Aug 11, 2023
@tkbstudios
Copy link
Author

ok, thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants