Make InterSphinxParser extensible #59
Conversation
jnothman
force-pushed
the
extensible-intersphinx
branch
from
078772a
to
a17ae46
Compare
Codecov Report
@@ Coverage Diff @@
## master #59 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 7 7
Lines 299 310 +11
Branches 38 40 +2
=====================================
+ Hits 299 310 +11
Continue to review full report at Codecov.
|
|
CI failure is flake8 in setup.py; nothing I touched. |
|
Jftr I'm computerless on a vacation right now so I won't be able to look at your tickets/PRs immediately. |
* allow INV_TO_TYPE mapping to be overridden via create_type method * allow ParserEntry creation to be overridden with create_entry method
jnothman
force-pushed
the
extensible-intersphinx
branch
from
a17ae46
to
f663bf7
Compare
|
Joel, I feel really bad for not coming back to you but I just have too much on my FOSS plate and doc2dash is a rather low-priority project for me nowadays (it does what I need :)). Would you be open to discuss ways to get you involved in a maintainer role? |
|
I know what you mean, by my foss load is also to heavy atm and I'm not yet sure I'm that dedicated to dash! I'll think about it... |
|
No problem, by no means understand that as any pressuring. I'll try to review/understand your patches this week. |
|
Would it be helpful if I created a |
|
Yeah seeing the motivation behind those changes would be def helpful! I’m at the PyCon sprints ATM so I might even find the time to have a closer look. 🙈 |
|
Well, given the time pressure, I've just hacked together a standalone script which works with this branch to produce docs with user guides: https://gist.github.com/jnothman/3f164a9f8f766009d29a95ab473ff972 I'm happy to incorporate a similar implementation in the doc2dash Intersphinx docs. Note that this currently over-generates: pages of API reference are also marked std:guide. I need to work out how to filter them out. |
src/doc2dash/parsers/intersphinx.py
Outdated
| if dash_type is None: | ||
| continue | ||
| for key, data in iteritems(inv_entries): | ||
| yield self.create_entry(dash_type, key, data) |
There was a problem hiding this comment.
we should allow create_entry to return None here.
Codecov Report
@@ Coverage Diff @@
## master #59 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 7 7
Lines 299 310 +11
Branches 38 40 +2
=====================================
+ Hits 299 310 +11
Continue to review full report at Codecov.
|
|
OK sorry for all the delays! I’m a terrible maintainer and I feel bad. Nevertheless, I’ve had finally a closer look. I’m not a fan of subclassing as a method for extension but your problem does look like classic specialization so I guess it’s the less terrible kind of subclassing. :) |
|
thanks!
…On 3 Jun 2017 4:48 pm, "Hynek Schlawack" ***@***.***> wrote:
Merged #59 <#59>.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#59 (comment)>, or mute the
thread
<https://github.com/notifications/unsubscribe-auth/AAEz639kxefXZjxZ-D5ZehS0melIBd1zks5sAQGogaJpZM4MXb4m>
.
|
Partial fix for #57