Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial support for DSA private keys. #49

Merged
merged 4 commits into from Jan 21, 2021

Conversation

adiroiban
Copy link
Contributor

Scope

This adds support for loading DSA private keys in legacy OpenSSH PEM format.

I was not able to find the RFC in which the format is defined.

I named it DSAPrivateKey and not OpenSSHDSAPrivateKey as you can also generate it using OpenSSL.

Pull Request Check List

This is just a friendly reminder about the most common mistakes. Please make sure that you tick all boxes. But please read our contribution guide at least once, it will save you unnecessary review cycles!

If an item doesn't apply to your pull request, check it anyway to make it apparent that there's nothing left to do.

  • Added tests for changed code.
  • Updated documentation for changed code.
    • New functions/classes have to be added to docs/api.rst by hand.
    • Changed/added classes/methods/functions have appropriate versionadded, versionchanged, or deprecated directives. Find the appropriate next version in our __init__.py file.
  • Documentation in .rst files is written using semantic newlines.
  • Changes (and possible deprecations) are documented in the changelog.

If you have any questions to any of the points above, just submit and ask! This checklist is here to help you, not to deter you from contributing!

@adiroiban adiroiban changed the title Initial support for DSA keys. Initial support for DSA private keys. Jan 20, 2021
@hynek hynek merged commit cffbfc1 into hynek:master Jan 21, 2021
@hynek
Copy link
Owner

hynek commented Jan 21, 2021

Thanks! I'll tweak the changelog a bit but I didn't want to do a review round around it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants