Skip to content
This repository has been archived by the owner on May 31, 2021. It is now read-only.

[Button] Documentation Is Outdated #350

Closed
0916dhkim opened this issue Sep 15, 2020 · 2 comments
Closed

[Button] Documentation Is Outdated #350

0916dhkim opened this issue Sep 15, 2020 · 2 comments
Assignees
@0916dhkim

Comments

@0916dhkim
Copy link
Contributor

Describe the bug
Props table and examples are not in sync with the actual source code of Button component.

https://github.com/dooboolab/dooboo-ui/blob/93d7e602c6bc0a42fa0696b7240392900612cf45/main/Button/README.md#L9-L27

https://github.com/dooboolab/dooboo-ui/blob/93d7e602c6bc0a42fa0696b7240392900612cf45/main/Button/README.md#L147-L171

https://github.com/dooboolab/dooboo-ui/blob/93d7e602c6bc0a42fa0696b7240392900612cf45/main/Button/index.tsx#L51-L68

  • outlined : Declared in Props but unused & undocumented.
  • color : Declared in Props but unused & undocumented.
  • Accent : Documented, but not declared in Props.
  • Secondary : Used in an example, but undocumented & undeclared.
@JeffGuKang
Copy link
Collaborator

It's your hawk's eye! I'll be wating for your PR.

@0916dhkim
Copy link
Contributor Author

@JeffGuKang Leave it to me, chief! I'll open a PR when I'm ready. Just wanted to make sure that I'm not missing anything here.

@JeffGuKang JeffGuKang changed the title Button Component Documentation Is Outdated [Button] Documentation Is Outdated Sep 16, 2020
@0916dhkim 0916dhkim mentioned this issue Sep 16, 2020
Merged
4 tasks
@hyochan hyochan mentioned this issue Jan 10, 2021
Merged
4 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@0916dhkim 0916dhkim

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@JeffGuKang @0916dhkim