Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show search bar prop #44

Open
advance512 opened this issue Jul 1, 2017 · 6 comments
Open

Show search bar prop #44

advance512 opened this issue Jul 1, 2017 · 6 comments

Comments

@advance512
Copy link
Contributor

Hi there,

Any chance you'll add a prop that allows to always (by default) show the search bar or always hide the search bar (as it is right now)?

That is, toggle default mode from 'normal' to 'filter' in the implementation.

@hyojin
Copy link
Owner

hyojin commented Jul 4, 2017

@advance512 Hi, currently no.
I think we can add 2 props for this. The first is to set default mode to normal or filter, and the other is to show filter icon or not to show. Is there any thing else that we might need?

@advance512
Copy link
Contributor Author

No, just this. Can we do it? :)

@hyojin
Copy link
Owner

hyojin commented Aug 1, 2017

Sure. but I'm focusing on the other project now, so maybe it takes time.

@advance512
Copy link
Contributor Author

@hyojin
fyi, your table is the main table in https://app.perfpie.com

@hyojin
Copy link
Owner

hyojin commented Aug 9, 2017

@advance512 I love to hear that! I've tried to sign in, but I'm hesitating to create account. lol
Btw, now we have 3 props to handle header toolbar, headerToolbarMode and filterValue and showHeaderToolbarFilterIcon. please check it on v0.18.2

@advance512
Copy link
Contributor Author

Will do.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants