Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove deferring of lifecycle events #171

Closed
jorgebucaran opened this issue Mar 25, 2017 · 1 comment
Closed

Remove deferring of lifecycle events #171

jorgebucaran opened this issue Mar 25, 2017 · 1 comment
Labels
discussion

Comments

@jorgebucaran
Copy link
Owner

jorgebucaran commented Mar 25, 2017 •
edited

Currently, lifecycle events: onCreate, onUpdate and onRemove are "deferred", using setTimeout.

IIRC this had to do with CodeMirror not refreshing correctly when using editor.refresh(), and this made it work, but it could have been me not knowing how to use CM.

It seems like if this is a CM's quirk (or even if it wasn't), we could move this out of HyperApp anyway. Your 3rd party library's wrapper / CM wrapper could always DIY defer/setTimeout.
@jorgebucaran
Copy link
Owner Author

https://github.com/hyperapp/hyperapp/releases/tag/0.8.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
discussion
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jorgebucaran