-
Notifications
You must be signed in to change notification settings - Fork 780
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename model to state. #173
Comments
Those terms make no difference to me, so no need to change it. |
Since we changed updates to actions, following the redux/Vuex semantics would be nice. Renaming to state makes sense 馃憤 |
|
I don't mind either, and the reason I chose model was TEA, but I also agree with some people finding model confusing since the most widespread term is state anyway. |
Hi @SkaterDad @nichoth @cdeutmeyer! If you have a minute, can you explain why you dislike / disapprove this notion? |
i upvoted |
@leeoniya You're right, but TEA also has the word update which we don't use anymore. @dodekeract Does your friend find hyperapp confusing just because of the world model? Seems an extreme position to take just because of a word. Just curious. |
@jbucaran No, mainly because of the differences to react/redux. He's currently trying to learn how to create SPAs and react/redux is the stuff he's currently attempting to learn. |
Gotcha. Good choice anyway. Reminds me of this. |
I'm really fine with it either way.. I just like sticking as close as possible to Elm terminology. |
In my mind "model" is more related to MVC and other OOP paradigms, and "state" is more connected to functional programming (where state management is made explicit instead of implicit). Mixed with the previous departure from the Elm architecture nomenclature, I'd go with "state". |
my reasoning was same as @danigb |
@jbucaran The community is mostly in favor of this change. Can we implement it? Also something somewhat related: when we link to code pens we should make sure they don't use hyperapp@latest since hyperapp is currently not stable enough for that. We should always link to hyperapp@0.8.x or similar. |
@dodekeract You are right, but latest refers to the published npm version, which is working fine AFIK. |
Yes, let's do so after #172 is merged please. |
@jbucaran Yes, it's working fine. right now. This leads to all hyperapp codepens breaking as soon as we publish breaking changes. This is especially relevant for forked codepens that inherit from our examples. |
@dodekeract Fortunately CodePens URLs don't change, so I just need to update the code. JSFiddle URLs do change, so I'll have to rewire everything or ditching JSFiddle. |
@jbucaran You don't see the problem. People fork our examples. This means they inherit this time bomb that destroys their codepens as soon as we introduce another breaking change. |
@dodekeract Ah, you're right... 馃槬 |
If the codepens use specific versions (as they should) then everything will be fine 馃槃 |
Why not just offer both versions? |
@AG-Systems Do you mean both model and state? I guess we could, but the idea is to come up with a clear API that is easy to teach and learn, also that would waste some bytes for no good reason. Check out #177, we're renaming model to state in 0.8.0. |
Yes @jbucaran |
Please 馃憤 or 馃憥.
The text was updated successfully, but these errors were encountered: