Fixes internal routing of URLs with query strings

[lukejacksonn]

app(
  view: {
    '/:a/:b': _ => h('button', { onclick: a.navigate }, 'Click Me')
  },
  actions: {
     navigate: (s,a,d) => a.router.go('/other/path?query=1')
  },
  plugins: [Router],
)

Given the above app being served from localhost (with history-api-fallback behavior). If you were to visit the URL http://localhost:8080/some/path?query=0 everything would work as expected:

• The router would match /:a/:b from location.pathname on startup and render the view.

You would be able to see a button. Clicking on the button fires a.router.go which gets passed a URL in the same form as the one matched on startup.. this time:

• No view is rendered because no match was found.

This is because when the page loads router.match gets passed the pathname part of the current URL (which evaluates to /some/path) whereas router.go tries to match the string it is passed without parsing out the pathname part (/other/path?query=1 instead of /other/path).

This PR is trying to ensure only the pathname part of a URL passed to router.go gets passed to router.match so that you can internal route to URLs with query parameters.

[codecov]

Codecov Report

Merging #217 into master will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff          @@
##           master   #217   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           4      4           
  Lines         164    164           
  Branches       43     43           
=====================================
  Hits          164    164

Impacted Files	Coverage Δ
src/router.js	100% <ø> (ø)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c12c292...2c32676. Read the comment docs.

[jorgebucaran]

@lukejacksonn Can't users split("?") themselves?

[lukejacksonn]

Then you lose that data from the url because it would not go through:

history.pushState({}, "", data)

which would mean if someone were then to refresh the newly visited page, the data that was in query string would no longer be accessible.

[jorgebucaran]

Thanks @lukejacksonn! 🎉