Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modernize #37

Merged
merged 49 commits into from
Feb 6, 2017
Merged

Modernize #37

merged 49 commits into from
Feb 6, 2017

Conversation

jorgebucaran
Copy link
Owner

@jorgebucaran jorgebucaran commented Feb 6, 2017

  • More ES6 idioms, and use webpack to create a UMD bundle.

See also: #38

@codecov-io
Copy link

codecov-io commented Feb 6, 2017

Codecov Report

❗ No coverage uploaded for pull request base (master@e79eac2). Click here to learn what that means.

@@            Coverage Diff            @@
##             master      #37   +/-   ##
=========================================
  Coverage          ?   37.95%           
=========================================
  Files             ?        2           
  Lines             ?      137           
  Branches          ?        0           
=========================================
  Hits              ?       52           
  Misses            ?       85           
  Partials          ?        0
Impacted Files Coverage Δ
src/h.js 33.33% <33.33%> (ø)
src/app.js 38.28% <38.28%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e79eac2...6a583e8. Read the comment docs.

@jorgebucaran jorgebucaran merged commit d1c1f5a into master Feb 6, 2017
@tunnckoCore
Copy link

tunnckoCore commented Feb 6, 2017

in webpack.config.js this is unused

const Wrapper = require("wrapper-webpack-plugin")

Also, why set all options of uglify to true explicitly, they defaults to true - only warnings is true by defaults.

@jorgebucaran
Copy link
Owner Author

Forgot to remove it! Thanks @tunnckoCore.

@jorgebucaran jorgebucaran deleted the modernize branch February 7, 2017 05:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants