Add lifecycle events documentation w/ working example 📚 #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@danigb Very nice! Thanks, what's EDIT: I see, can you provide a full working example? I can create a codepen for it and link to it later. |
|
Great! The |
|
@danigb LOL, right. Can we have simple working example? |
|
With a working example now |
maraisr
suggested changes
Feb 6, 2017
README.md
Outdated
|
|
||
| ```js | ||
| function repaint(canvas, model) { | ||
| var ctx = canvas.getContext('2d') |
There was a problem hiding this comment.
Could you please spell this out, context i know its a pain, but to most people ctx means nothing! Love the contrib though! ❤️
There was a problem hiding this comment.
Sorry, I didn't read you comment. Fixing it...
|
@danigb Awesome, thanks! |
jorgebucaran
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add some documentation to README.md with a
canvasexample.