Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests #60

Merged
merged 3 commits into from
Feb 9, 2017
Merged

Tests #60

merged 3 commits into from
Feb 9, 2017

Conversation

jorgebucaran
Copy link
Owner

@jorgebucaran jorgebucaran commented Feb 8, 2017

Thank you all @danigb and @maraisr ❤️

Marais Rossouw and others added 3 commits February 8, 2017 08:05
* TODO: All properties are optional
* Test: style view with a js object
* Test a view that uses 'h' instead of 'html'
* SVG
@codecov
Copy link

codecov bot commented Feb 8, 2017

Codecov Report

Merging #60 into master will increase coverage by 33.57%.

@@             Coverage Diff             @@
##           master      #60       +/-   ##
===========================================
+ Coverage   39.28%   72.85%   +33.57%     
===========================================
  Files           3        3               
  Lines         140      140               
===========================================
+ Hits           55      102       +47     
+ Misses         85       38       -47
Impacted Files Coverage Δ
app.js 69.1% <ø> (+38.21%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9f2f5d1...c3802f4. Read the comment docs.

@jorgebucaran jorgebucaran merged commit c3802f4 into master Feb 9, 2017

const { app, html } = require("../hx")
const { app, html, h } = require("../hx")

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't this be const {app, html, h} = require('../')?

@jorgebucaran jorgebucaran deleted the tests branch February 15, 2017 10:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants